linux-4.6-rc5/fs/ntfs/inode.c:1274]: (style) Redundant condition

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
Report Content as Inappropriate

linux-4.6-rc5/fs/ntfs/inode.c:1274]: (style) Redundant condition

David Binderman
Hello there,

[linux-4.6-rc5/fs/ntfs/inode.c:1274]: (style) Redundant condition: ni.type==AT_DATA. 'ni.type!=AT_DATA || (ni.type==AT_DATA && ni.name_len)' is equivalent to 'ni.type!=AT_DATA || ni.name_len'

Source code is

           if ((ni->type != AT_DATA) || (ni->type == AT_DATA &&
                    ni->name_len)) {

Suggest new code

           if ((ni->type != AT_DATA) || ni->name_len) {


David Binderman
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!;130105516;z
Linux-NTFS-Dev mailing list
[hidden email]